Wireshark-bugs: [Wireshark-bugs] [Bug 2319] New dissector called xcsl/ xgen interface specification - call specification language

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 4 Mar 2008 07:18:11 +0000 (GMT)

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2319





--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-03-04 07:18:08 GMT ---
Here some remarks:
We're called Wireshark for some time now, please update header.
What does dissect_xcsl() do and what is xcsl_handle for?
It's customary to have the field definitions near the end of the source file.
In dissect_xcsl_tcp() why is offset volatile?
In header field definitions it not needed to repeat the fieldname in the field
description, just use NULL.
Request is used as boolean, please define as gboolean.
tvb_reported_length_remaining() can also return -1, not breaking your loop.
In get_next_item() maxlen should be maximized to the length of the str buffer
(4096) to avoid buffer overflow.
In get_next_item() o is tracking the offset as well as l. Just l will do.
Why use proto_tree_add_string_format() iso proto_tree_add_item()? Please go
with default formating.
why use 'code = ....' iso. value_string, and that in field defintion?


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.