Wireshark-bugs: [Wireshark-bugs] [Bug 2051] Crash in packet_ansi_a.c (bsap)

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 3 Dec 2007 17:07:16 +0000 (GMT)

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2051





------- Comment #10 from jeff.morriss@xxxxxxxxxxx  2007-12-03 17:07 GMT -------
(In reply to comment #8)
> That should not be a link...
> We should change the code that looks for an URL while rendering the tree and
> make sure that it creates a link only for a valid protocol (c: is not a valid
> protocol).

I thought only things marked with PROTO_ITEM_SET_URL() would be marked as
URLs...


Also CFRelease() means that we're in the HAVE_OS_X_FRAMEWORKS code in
brownser_open_url().  The GTK2 code for the same has

g_return_val_if_fail (url != NULL, FALSE);

presumably to avoid crashes.  Maybe that code should be moved to the top of the
function (though I'd really like to understand why this item is being marked as
a URL first).


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.