Wireshark-bugs: [Wireshark-bugs] [Bug 1957] New Dissector: EPCglobal Low-Level Reader Protocol

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 6 Nov 2007 21:15:19 +0000 (GMT)

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1957





------- Comment #4 from ronniesahlberg@xxxxxxxxx  2007-11-06 21:15 GMT -------
Why do you use all these wrappers?

Such as :
+    pulData= (unsigned long *) llrp_BufferRead(buffer, 4, &ulReadBytes);
+    if(ulReadBytes!= 4)
+    {
+        if(context->parse_error_handler!= NULL)
+        {
+            context->parse_error_handler(context,
LLRP_PARSE_ERROR_DATA_UNDERFL
OW, 
+             "llrp_ParseMessage: Failed to read message length bytes");
+        }
+        return;
+    }
+    ulLength= llrp_ntohl(*pulData);

which should really just be:
  ulLength = tvb_get_ntohl(tvb, offset);


this makes the dissector very hard to read and hard to maintain.
can you get rid of these wrappers and recode it more in the standard wireshark
style?   i.e. get rid of the function llrp_BufferRead() completely and all
other wrappers as well.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.