Wireshark-bugs: [Wireshark-bugs] [Bug 1675] bad cast fals Build on trunk (r22223 of wireshark/epan/dissectors/packet-pe r.c)

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 10 Jul 2007 15:33:08 +0000 (GMT)

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1675





------- Comment #1 from jeff.morriss@xxxxxxxxxxx  2007-07-10 15:33 GMT -------
The problematic code:

>   actx->created_item = proto_tree_add_ipv4(tree, hf_index, tvb, val_start,
> val_length, (guint32)pbytes);

is passing the value of the *pointer* as the IPv4 address which is presumably
not what was intended.  A simple fix would be to add a dereference:
"(guint32)*pbytes" but I suppose that assumes pbytes starts on a 4-byte
boundary which may or may not be the case (e.g., it might cause problems on
SPARCs).  Need to look again when I'm more awake.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.