Wireshark-bugs: [Wireshark-bugs] [Bug 1670] bacapp.c: BACnetEventTransitionBits decoded as Enumerated instead of Bit String

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 5 Jul 2007 22:19:06 +0000 (GMT)

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1670


steve@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #723 is|0                           |1
           obsolete|                            |




------- Comment #4 from steve@xxxxxxxxx  2007-07-05 22:19 GMT -------
Created an attachment (id=724)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=724&action=view)
Proposed patch to packet-bacapp dissector

For the  BACnet GetEventInformation-ACK request dissector:
1. Corrected BitString decoding for acknowledgedTransitions and eventEnable.

2. Corrected the ability to decode more than one event.

3. Grouped each item of the sequence using subtrees.  Added more informative
text to Priority and Timestamp.

4. Corrected eventState to use BACnetEventState enumeration instead of
BACnetEventStateFilter.

See attached patch.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.