http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1632
Summary: Dissector for Fibre Channel ELS has bits for FCP PRLI
param wrong
Product: Wireshark
Version: 0.99.6
Platform: All
OS/Version: All
Status: NEW
Severity: Minor
Priority: Low
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: joe@xxxxxxxxxxxxxxxx
Build Information:
wireshark 0.99.6 (SVN Rev 21910)
Copyright 1998-2007 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled with GTK+ 2.8.3, with GLib 2.8.1, with libpcap 0.9.2, with libz 1.2.3,
with libpcre 6.2, without Net-SNMP, without ADNS, without Lua, with GnuTLS
1.2.5, with Gcrypt 1.2.1, without Kerberos, without PortAudio, without AirPcap.
Running on Linux 2.6.13-15.13-default, with libpcap version 0.9.2.
Built using gcc 4.0.2 20050901 (prerelease) (SUSE Linux).
--
The dissector for the Fibre Channel ELS PRLI (process login) uses
mask 0x2000 to select the bit for FCP "retry requested/reply" when it should
be bit 9 (0x200).
Similarly, it uses a mask of 0x1000 for "retry", which is supposed to be bit 8.
Here is a patch:
--- epan/dissectors/packet-fcels.c (revision 21989)
+++ epan/dissectors/packet-fcels.c (working copy)
@@ -2477,13 +2477,13 @@
HFILL}},
{ &hf_fcels_fcpflags_trireq,
{"Task Retry Ident", "fcels.fcpflags.trireq", FT_BOOLEAN, 32,
- TFS(&tfs_fc_fcels_fcpflags_trireq), 0x2000, "", HFILL}},
+ TFS(&tfs_fc_fcels_fcpflags_trireq), 1 << 9, "", HFILL}},
{ &hf_fcels_fcpflags_trirep,
{"Task Retry Ident", "fcels.fcpflags.trirep", FT_BOOLEAN, 32,
- TFS(&tfs_fc_fcels_fcpflags_trirep), 0x2000, "", HFILL}},
+ TFS(&tfs_fc_fcels_fcpflags_trirep), 1 << 9, "", HFILL}},
{ &hf_fcels_fcpflags_retry,
{"Retry", "fcels.fcpflags.retry", FT_BOOLEAN, 32,
- TFS(&tfs_fc_fcels_fcpflags_retry), 0x1000, "", HFILL}},
+ TFS(&tfs_fc_fcels_fcpflags_retry), 1 << 8, "", HFILL}},
{ &hf_fcels_fcpflags_ccomp,
{"Comp", "fcels.fcpflags.ccomp", FT_BOOLEAN, 32,
TFS(&tfs_fc_fcels_fcpflags_ccomp), 0x0080, "", HFILL}},
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
