http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1383
------- Comment #3 from joost@xxxxxxxxxx 2007-02-25 12:49 GMT -------
(In reply to comment #2)
> Why all this data retrieval and adding by type? I mean stuff like this:
> epmd_dist_high = tvb_get_ntohs(tvb, 6);
> proto_tree_add_uint(tree, hf_epmd_dist_high, tvb, 6, 2,
> epmd_dist_high);
> why not using proto_tree_add_item()?
> Why not using a running offset? It's usually easier to maintain, you could even
> consider using pvt_cursor.
>
Thanks, I will have a look at your suggestions.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
